staging: gpib: pc2: struct gpib_interface
authorMichael Rubin <matchstick@neverthere.org>
Thu, 17 Apr 2025 00:32:44 +0000 (00:32 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Apr 2025 09:12:55 +0000 (11:12 +0200)
Using Linux code style for struct gpib_interface.

Adhering to Linux code style.

Reported by checkpatch.pl

In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.

Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250417003246.84445-17-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gpib/pc2/pc2_gpib.c

index 48f57a917d0da0f5b765af23ee5d684ac214c7f9..fd191d24d7a60cdec40d14322f911cfb93112aa7 100644 (file)
@@ -519,7 +519,7 @@ static void pc2_2a_detach(struct gpib_board *board)
        pc2a_common_detach(board, pc2_2a_iosize);
 }
 
-static gpib_interface_t pc2_interface = {
+static struct gpib_interface pc2_interface = {
        .name = "pcII",
        .attach =       pc2_attach,
        .detach =       pc2_detach,
@@ -547,7 +547,7 @@ static gpib_interface_t pc2_interface = {
        .return_to_local = pc2_return_to_local,
 };
 
-static gpib_interface_t pc2a_interface = {
+static struct gpib_interface pc2a_interface = {
        .name = "pcIIa",
        .attach =       pc2a_attach,
        .detach =       pc2a_detach,
@@ -575,7 +575,7 @@ static gpib_interface_t pc2a_interface = {
        .return_to_local = pc2_return_to_local,
 };
 
-static gpib_interface_t pc2a_cb7210_interface = {
+static struct gpib_interface pc2a_cb7210_interface = {
        .name = "pcIIa_cb7210",
        .attach =       pc2a_cb7210_attach,
        .detach =       pc2a_detach,
@@ -603,7 +603,7 @@ static gpib_interface_t pc2a_cb7210_interface = {
        .return_to_local = pc2_return_to_local,
 };
 
-static gpib_interface_t pc2_2a_interface = {
+static struct gpib_interface pc2_2a_interface = {
        .name = "pcII_IIa",
        .attach =       pc2_2a_attach,
        .detach =       pc2_2a_detach,