drm/i915: pass dev_priv explicitly to TRANS_MULT
authorJani Nikula <jani.nikula@intel.com>
Tue, 4 Jun 2024 15:25:30 +0000 (18:25 +0300)
committerJani Nikula <jani.nikula@intel.com>
Fri, 7 Jun 2024 08:13:17 +0000 (11:13 +0300)
Avoid the implicit dev_priv local variable use, and pass dev_priv
explicitly to the TRANS_MULT register macro.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/7ea79208a81fd5c3b021bcd8e1f9f90607716d82.1717514638.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_display.c
drivers/gpu/drm/i915/i915_reg.h
drivers/gpu/drm/i915/intel_gvt_mmio_table.c

index 81ae72648e8e8bb04aede55620073de0278dc058..e7ee4970e306d88867b60e901c8a652ad79719a1 100644 (file)
@@ -1646,7 +1646,7 @@ static void hsw_configure_cpu_transcoder(const struct intel_crtc_state *crtc_sta
                intel_vrr_set_transcoder_timings(crtc_state);
 
        if (cpu_transcoder != TRANSCODER_EDP)
-               intel_de_write(dev_priv, TRANS_MULT(cpu_transcoder),
+               intel_de_write(dev_priv, TRANS_MULT(dev_priv, cpu_transcoder),
                               crtc_state->pixel_multiplier - 1);
 
        hsw_set_frame_start_delay(crtc_state);
@@ -3861,7 +3861,7 @@ static bool hsw_get_pipe_config(struct intel_crtc *crtc,
            !transcoder_is_dsi(pipe_config->cpu_transcoder)) {
                pipe_config->pixel_multiplier =
                        intel_de_read(dev_priv,
-                                     TRANS_MULT(pipe_config->cpu_transcoder)) + 1;
+                                     TRANS_MULT(dev_priv, pipe_config->cpu_transcoder)) + 1;
        } else {
                pipe_config->pixel_multiplier = 1;
        }
index 8e312aa8ca71daf98811282b8c981e8a3bcca462..e72be82445ca1c54a2d65228e1a478569f9b7208 100644 (file)
 #define BCLRPAT(dev_priv, trans)               _MMIO_TRANS2(dev_priv, (trans), _BCLRPAT_A)
 #define TRANS_VSYNCSHIFT(dev_priv, trans)      _MMIO_TRANS2(dev_priv, (trans), _TRANS_VSYNCSHIFT_A)
 #define PIPESRC(dev_priv, pipe)                _MMIO_TRANS2(dev_priv, (pipe), _PIPEASRC)
-#define TRANS_MULT(trans)      _MMIO_TRANS2(dev_priv, (trans), _TRANS_MULT_A)
+#define TRANS_MULT(dev_priv, trans)    _MMIO_TRANS2(dev_priv, (trans), _TRANS_MULT_A)
 
 /* VRR registers */
 #define _TRANS_VRR_CTL_A               0x60420
index ff561a1e0fd341a61537393647808ef97b9d5e64..600e89148f7751480dddb06cb2c7016f59baef23 100644 (file)
@@ -506,9 +506,9 @@ static int iterate_generic_mmio(struct intel_gvt_mmio_table_iter *iter)
        MMIO_D(GAMMA_MODE(PIPE_A));
        MMIO_D(GAMMA_MODE(PIPE_B));
        MMIO_D(GAMMA_MODE(PIPE_C));
-       MMIO_D(TRANS_MULT(TRANSCODER_A));
-       MMIO_D(TRANS_MULT(TRANSCODER_B));
-       MMIO_D(TRANS_MULT(TRANSCODER_C));
+       MMIO_D(TRANS_MULT(dev_priv, TRANSCODER_A));
+       MMIO_D(TRANS_MULT(dev_priv, TRANSCODER_B));
+       MMIO_D(TRANS_MULT(dev_priv, TRANSCODER_C));
        MMIO_D(HSW_TVIDEO_DIP_CTL(dev_priv, TRANSCODER_A));
        MMIO_D(HSW_TVIDEO_DIP_CTL(dev_priv, TRANSCODER_B));
        MMIO_D(HSW_TVIDEO_DIP_CTL(dev_priv, TRANSCODER_C));