media: vidtv: fix initialization of the network_id field at SDT
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Sun, 20 Sep 2020 06:34:55 +0000 (08:34 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 1 Oct 2020 07:20:35 +0000 (09:20 +0200)
This field should point to the network ID, and has different
ranges for cable, terrestrial or satellite. It also has
an special range for temporary private usage.

For now, let's use the temporary private one. Once the
Network Information Table (NIT) gets added, this should be
reviewed.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/test-drivers/vidtv/vidtv_psi.c

index 8cdf645b4fddef5119b58af668fa4f5587fe1c70..5fe3fbb765b89f7980c9db1124356407c045ac34 100644 (file)
@@ -1107,7 +1107,14 @@ struct vidtv_psi_table_sdt *vidtv_psi_sdt_table_init(u16 transport_stream_id)
        sdt->header.section_id   = 0;
        sdt->header.last_section = 0;
 
-       sdt->network_id = cpu_to_be16(transport_stream_id);
+       /*
+        * FIXME: The network_id range from 0xFF01 to 0xFFFF is used to
+        * indicate temporary private use. For now, let's use the first
+        * value.
+        * This can be changed to something more useful, when support for
+        * NIT gets added
+        */
+       sdt->network_id = cpu_to_be16(0xff01);
        sdt->reserved = RESERVED;
 
        vidtv_psi_sdt_table_update_sec_len(sdt);