drm/panel-sharp-ls060t1sx01: Drop custom DSI write macro
authorJavier Martinez Canillas <javierm@redhat.com>
Sat, 7 Jan 2023 19:18:19 +0000 (20:18 +0100)
committerJavier Martinez Canillas <javierm@redhat.com>
Wed, 11 Jan 2023 17:50:54 +0000 (18:50 +0100)
There is a macro for this already in the <drm/drm_mipi_dsi.h> header, use
that instead and delete the custom DSI write macro defined in the driver.

Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230107191822.3787147-11-javierm@redhat.com
drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c

index 8a4e0c1fe73ff239d8624af0a92b10291d8044d5..68f52eaaf4fa57ec50aecb629a92507bfb6bbf8c 100644 (file)
@@ -32,12 +32,6 @@ static inline struct sharp_ls060 *to_sharp_ls060(struct drm_panel *panel)
        return container_of(panel, struct sharp_ls060, panel);
 }
 
-#define dsi_dcs_write_seq(dsi, seq...) ({                              \
-               static const u8 d[] = { seq };                          \
-                                                                       \
-               mipi_dsi_dcs_write_buffer(dsi, d, ARRAY_SIZE(d));       \
-       })
-
 static void sharp_ls060_reset(struct sharp_ls060 *ctx)
 {
        gpiod_set_value_cansleep(ctx->reset_gpio, 0);
@@ -56,17 +50,8 @@ static int sharp_ls060_on(struct sharp_ls060 *ctx)
 
        dsi->mode_flags |= MIPI_DSI_MODE_LPM;
 
-       ret = dsi_dcs_write_seq(dsi, 0xbb, 0x13);
-       if (ret < 0) {
-               dev_err(dev, "Failed to send command: %d\n", ret);
-               return ret;
-       }
-
-       ret = dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_MEMORY_START);
-       if (ret < 0) {
-               dev_err(dev, "Failed to send command: %d\n", ret);
-               return ret;
-       }
+       mipi_dsi_dcs_write_seq(dsi, 0xbb, 0x13);
+       mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_MEMORY_START);
 
        ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
        if (ret < 0) {