projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
ade8a86
)
dmaengine: idxd: fix uninit var for alt_drv
author
Dave Jiang
<dave.jiang@intel.com>
Wed, 21 Jul 2021 18:35:03 +0000
(11:35 -0700)
committer
Vinod Koul
<vkoul@kernel.org>
Wed, 28 Jul 2021 12:25:40 +0000
(17:55 +0530)
0-day detected uninitialized alt_drv variable in the bind_store() function.
The branch can be taken when device is not idxd device or wq 'struct
device'. Init alt_drv to NULL.
Fixes:
6e7f3ee97bbe
("dmaengine: idxd: move dsa_drv support to compatible mode")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Link:
https://lore.kernel.org/r/162689250332.2114335.636367120454420852.stgit@djiang5-desk3.ch.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/idxd/compat.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/dma/idxd/compat.c
b/drivers/dma/idxd/compat.c
index d67746ee0c1a4a26ee54477543b5bc87a36d35a0..d7616c240dcd41be44883ff37f45eefa3eb8bae6 100644
(file)
--- a/
drivers/dma/idxd/compat.c
+++ b/
drivers/dma/idxd/compat.c
@@
-34,7
+34,7
@@
static ssize_t bind_store(struct device_driver *drv, const char *buf, size_t cou
{
struct bus_type *bus = drv->bus;
struct device *dev;
- struct device_driver *alt_drv;
+ struct device_driver *alt_drv
= NULL
;
int rc = -ENODEV;
struct idxd_dev *idxd_dev;