net: hisilicon: hns_dsaf_mac: fix OF node leak in hns_mac_get_info()
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tue, 27 Aug 2024 14:44:20 +0000 (16:44 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 29 Aug 2024 00:55:23 +0000 (17:55 -0700)
Driver is leaking OF node reference from
of_parse_phandle_with_fixed_args() in hns_mac_get_info().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240827144421.52852-3-krzysztof.kozlowski@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c

index f75668c479351913e20f54c103125bbd345b8a47..616a2768e5048ab1d85ec7ea45471ab573ef7261 100644 (file)
@@ -933,6 +933,7 @@ static int hns_mac_get_info(struct hns_mac_cb *mac_cb)
                        mac_cb->cpld_ctrl = NULL;
                } else {
                        syscon = syscon_node_to_regmap(cpld_args.np);
+                       of_node_put(cpld_args.np);
                        if (IS_ERR_OR_NULL(syscon)) {
                                dev_dbg(mac_cb->dev, "no cpld-syscon found!\n");
                                mac_cb->cpld_ctrl = NULL;