drm/panel: y030xx067a: Make use of the helper function dev_err_probe()
authorCai Huoqing <caihuoqing@baidu.com>
Thu, 16 Sep 2021 10:46:57 +0000 (18:46 +0800)
committerSam Ravnborg <sam@ravnborg.org>
Thu, 14 Oct 2021 20:12:30 +0000 (22:12 +0200)
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210916104658.11834-1-caihuoqing@baidu.com
drivers/gpu/drm/panel/panel-abt-y030xx067a.c

index 2d8794d495d08e62d749909f0e87ba040843e01e..1b5d8f755b1257052bc11588f489ac54ff82398a 100644 (file)
@@ -272,16 +272,14 @@ static int y030xx067a_probe(struct spi_device *spi)
                return -EINVAL;
 
        priv->supply = devm_regulator_get(dev, "power");
-       if (IS_ERR(priv->supply)) {
-               dev_err(dev, "Failed to get power supply\n");
-               return PTR_ERR(priv->supply);
-       }
+       if (IS_ERR(priv->supply))
+               return dev_err_probe(dev, PTR_ERR(priv->supply),
+                                    "Failed to get power supply\n");
 
        priv->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
-       if (IS_ERR(priv->reset_gpio)) {
-               dev_err(dev, "Failed to get reset GPIO\n");
-               return PTR_ERR(priv->reset_gpio);
-       }
+       if (IS_ERR(priv->reset_gpio))
+               return dev_err_probe(dev, PTR_ERR(priv->reset_gpio),
+                                    "Failed to get reset GPIO\n");
 
        drm_panel_init(&priv->panel, dev, &y030xx067a_funcs,
                       DRM_MODE_CONNECTOR_DPI);