netdevsim: remove redundant variable ret
authorJinpeng Cui <cui.jinpeng2@zte.com.cn>
Wed, 31 Aug 2022 15:43:29 +0000 (15:43 +0000)
committerJakub Kicinski <kuba@kernel.org>
Fri, 2 Sep 2022 03:50:48 +0000 (20:50 -0700)
Return value directly from nsim_dev_reload_create()
instead of getting value from redundant variable ret.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
Link: https://lore.kernel.org/r/20220831154329.305372-1-cui.jinpeng2@zte.com.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/netdevsim/dev.c

index efea94c27880afaeb5568e29ee9b0785d8d55f56..794fc0cc73b8870ce744dea2ef1b35d90cea2888 100644 (file)
@@ -965,7 +965,6 @@ static int nsim_dev_reload_up(struct devlink *devlink, enum devlink_reload_actio
                              struct netlink_ext_ack *extack)
 {
        struct nsim_dev *nsim_dev = devlink_priv(devlink);
-       int ret;
 
        if (nsim_dev->fail_reload) {
                /* For testing purposes, user set debugfs fail_reload
@@ -976,8 +975,8 @@ static int nsim_dev_reload_up(struct devlink *devlink, enum devlink_reload_actio
        }
 
        *actions_performed = BIT(DEVLINK_RELOAD_ACTION_DRIVER_REINIT);
-       ret = nsim_dev_reload_create(nsim_dev, extack);
-       return ret;
+
+       return nsim_dev_reload_create(nsim_dev, extack);
 }
 
 static int nsim_dev_info_get(struct devlink *devlink,