media: i2c: imx219: Fix test pattern window for 640x480 mode
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Sun, 24 Sep 2023 15:32:54 +0000 (18:32 +0300)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Sat, 7 Oct 2023 08:55:46 +0000 (10:55 +0200)
The 640x480 mode specifies incorrect values for the TP_WINDOW_WIDTH and
TP_WINDOW_HEIGHT registers, which likely got copied from the 1640x1232
mode. They should be identical to the X_OUTPUT_SIZE and Y_OUTPUT_SIZE
registers as for all the other modes, to avoid cropping the test
pattern. Fix them.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/i2c/imx219.c

index a14de8f3dee73518bbbc1e9b85e066bc74f72b2c..cf55c59cbb7f413f2ee043e686fea03e96c430c7 100644 (file)
@@ -263,8 +263,8 @@ static const struct cci_reg_sequence mode_640_480_regs[] = {
        { IMX219_REG_Y_ADD_END_A, 1711 },
        { IMX219_REG_X_OUTPUT_SIZE, 640 },
        { IMX219_REG_Y_OUTPUT_SIZE, 480 },
-       { IMX219_REG_TP_WINDOW_WIDTH, 1640 },
-       { IMX219_REG_TP_WINDOW_HEIGHT, 1232 },
+       { IMX219_REG_TP_WINDOW_WIDTH, 640 },
+       { IMX219_REG_TP_WINDOW_HEIGHT, 480 },
 };
 
 static const struct cci_reg_sequence raw8_framefmt_regs[] = {