drm/qxl: remove set but not used variables 'driver, qbo'
authorYueHaibing <yuehaibing@huawei.com>
Mon, 12 Nov 2018 13:32:36 +0000 (13:32 +0000)
committerGerd Hoffmann <kraxel@redhat.com>
Wed, 14 Nov 2018 13:21:04 +0000 (14:21 +0100)
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/qxl/qxl_release.c: In function 'qxl_release_fence_buffer_objects':
drivers/gpu/drm/qxl/qxl_release.c:431:17: warning:
 variable 'qbo' set but not used [-Wunused-but-set-variable]

drivers/gpu/drm/qxl/qxl_release.c:430:24: warning:
 variable 'driver' set but not used [-Wunused-but-set-variable]

'qbo' not used since commit f2c24b83ae90 ("drm/ttm: flip the switch, and convert
to dma_fence")

And 'driver' never used since introduction in
8002db6336dd ("qxl: convert qxl driver to proper use for reservations")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1542029556-88107-1-git-send-email-yuehaibing@huawei.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
drivers/gpu/drm/qxl/qxl_release.c

index 3813ec19890067d0d8cb39bc7e7ac6f4bbb9bef8..0a693fede05ebf218bb9bd8a077be9178cf56e7d 100644 (file)
@@ -427,8 +427,6 @@ void qxl_release_fence_buffer_objects(struct qxl_release *release)
        struct ttm_buffer_object *bo;
        struct ttm_bo_global *glob;
        struct ttm_bo_device *bdev;
-       struct ttm_bo_driver *driver;
-       struct qxl_bo *qbo;
        struct ttm_validate_buffer *entry;
        struct qxl_device *qdev;
 
@@ -449,14 +447,12 @@ void qxl_release_fence_buffer_objects(struct qxl_release *release)
                       release->id | 0xf0000000, release->base.seqno);
        trace_dma_fence_emit(&release->base);
 
-       driver = bdev->driver;
        glob = bdev->glob;
 
        spin_lock(&glob->lru_lock);
 
        list_for_each_entry(entry, &release->bos, head) {
                bo = entry->bo;
-               qbo = to_qxl_bo(bo);
 
                reservation_object_add_shared_fence(bo->resv, &release->base);
                ttm_bo_add_to_lru(bo);