mmc: sdhci-milbeaut: Remove redundant platform_get_irq error message
authorYueHaibing <yuehaibing@huawei.com>
Thu, 16 Jan 2020 14:43:22 +0000 (22:43 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 20 Jan 2020 10:52:26 +0000 (11:52 +0100)
platform_get_irq() will call dev_err() itself on failure,
so there is no need for the driver to also do this.
This is detected by coccinelle.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/20200116144322.57308-1-yuehaibing@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-milbeaut.c

index e6245b7bda21119febc0145c9dcb9eaa760383a2..92f30a1db4352c9be4fefb17e31c59afa91d42a7 100644 (file)
@@ -246,10 +246,8 @@ static int sdhci_milbeaut_probe(struct platform_device *pdev)
        struct f_sdhost_priv *priv;
 
        irq = platform_get_irq(pdev, 0);
-       if (irq < 0) {
-               dev_err(dev, "%s: no irq specified\n", __func__);
+       if (irq < 0)
                return irq;
-       }
 
        host = sdhci_alloc_host(dev, sizeof(struct f_sdhost_priv));
        if (IS_ERR(host))