selftests: ublk: fix recover test
authorMing Lei <ming.lei@redhat.com>
Mon, 21 Apr 2025 23:59:41 +0000 (07:59 +0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 23 Apr 2025 19:58:55 +0000 (13:58 -0600)
When adding recovery test:

- 'break' is missed for handling '-g' argument

- test name of test_generic_05.sh is wrong

So fix the two.

Fixes: 57e13a2e8cd2 ("selftests: ublk: support user recovery")
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Uday Shankar <ushankar@purestorage.com>
Link: https://lore.kernel.org/r/20250421235947.715272-2-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
tools/testing/selftests/ublk/kublk.c
tools/testing/selftests/ublk/test_generic_05.sh

index 759f0663714613ea5adc8f9eb98ab67171998681..e57a1486bb48d8aa0340f96d65c3f0bbcf71efff 100644 (file)
@@ -1354,6 +1354,7 @@ int main(int argc, char *argv[])
                        value = strtol(optarg, NULL, 10);
                        if (value)
                                ctx.flags |= UBLK_F_NEED_GET_DATA;
+                       break;
                case 0:
                        if (!strcmp(longopts[option_idx].name, "debug_mask"))
                                ublk_dbg_mask = strtol(optarg, NULL, 16);
index 714630b4b3295f564f051813fb8c27c87b9146d6..3bb00a3474020196e349c1173484b1ffb9163e13 100755 (executable)
@@ -3,7 +3,7 @@
 
 . "$(cd "$(dirname "$0")" && pwd)"/test_common.sh
 
-TID="generic_04"
+TID="generic_05"
 ERR_CODE=0
 
 ublk_run_recover_test()