drm/i915/error: drop dmesg suggestion to file bugs on GPU hangs

We haven't updated the DRIVER_TIMESTAMP since commit 3570bd989acc
("drm/i915: Update DRIVER_DATE to 20230929") 1½ years ago. Before then,
the previous update was commit 139caf7ca286 ("drm/i915: Update
DRIVER_DATE to 20201103") 4+ years ago. The DRIVER_DATE has also been
removed altogether.

We've used the DRIVER_TIMESTAMP to log suggestions to file bugs on GPU
hangs when they happen on a driver less than six months old. Combined
with the sporadic DRIVER_TIMESTAMP updates, we really haven't logged the
suggestions for years.

Just stop logging the suggestion to file bugs altogether, and remove
DRIVER_TIMESTAMP. This doesn't really change anything wrt to logging GPU
errors or how we handle bugs. And effectively we already stopped logging
the message a year ago when we stopped updating DRIVER_TIMESTAMP.

Instead, add an unconditional message about the GPU error state
location.

Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Tvrtko Ursulin <tursulin@ursulin.net>
Acked-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Link: https://lore.kernel.org/r/20250429115055.2133143-1-jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>

diff --git a/drivers/gpu/drm/i915/i915_driver.h b/drivers/gpu/drm/i915/i915_driver.h
index 4b67ad9a61cdacbd8aa92eb1999431021ca5ed5f..1e95ecb2a163fdb222bca8d4e57b478eabed9ff3 100644 (file)
--- a/drivers/gpu/drm/i915/i915_driver.h
+++ b/drivers/gpu/drm/i915/i915_driver.h
@@ -15,7 +15,6 @@ struct drm_printer;
 
 #define DRIVER_NAME            "i915"
 #define DRIVER_DESC            "Intel Graphics"
-#define DRIVER_TIMESTAMP       1695980603
 
 extern const struct dev_pm_ops i915_pm_ops;
 

diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index 2dcc869c1332bea24364d14a642b280adf4dc5ce..5a853e146fe6212bb0477c19d55870cb68dbc60e 100644 (file)
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -2133,7 +2133,6 @@ i915_gpu_coredump(struct intel_gt *gt, intel_engine_mask_t engine_mask, u32 dump
 void i915_error_state_store(struct i915_gpu_coredump *error)
 {
        struct drm_i915_private *i915;
-       static bool warned;
 
        if (IS_ERR_OR_NULL(error))
                return;
@@ -2147,16 +2146,8 @@ void i915_error_state_store(struct i915_gpu_coredump *error)
 
        i915_gpu_coredump_get(error);
 
-       if (!xchg(&warned, true) &&
-           ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) {
-               pr_info("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n");
-               pr_info("Please file a _new_ bug report at https://gitlab.freedesktop.org/drm/intel/issues/new.\n");
-               pr_info("Please see https://drm.pages.freedesktop.org/intel-docs/how-to-file-i915-bugs.html for details.\n");
-               pr_info("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n");
-               pr_info("The GPU crash dump is required to analyze GPU hangs, so please always attach it.\n");
-               pr_info("GPU crash dump saved to /sys/class/drm/card%d/error\n",
-                       i915->drm.primary->index);
-       }
+       drm_info(&i915->drm, "GPU error state saved to /sys/class/drm/card%d/error\n",
+                i915->drm.primary->index);
 }
 
 /**