ublk: don't log uring_cmd cmd_op in ublk_dispatch_req()
authorCaleb Sander Mateos <csander@purestorage.com>
Wed, 30 Apr 2025 22:52:30 +0000 (16:52 -0600)
committerJens Axboe <axboe@kernel.dk>
Fri, 2 May 2025 15:22:30 +0000 (09:22 -0600)
cmd_op is either UBLK_U_IO_FETCH_REQ, UBLK_U_IO_COMMIT_AND_FETCH_REQ,
or UBLK_U_IO_NEED_GET_DATA. Which one isn't particularly interesting
and is already recorded by the log line in __ublk_ch_uring_cmd().

Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20250430225234.2676781-6-csander@purestorage.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/ublk_drv.c

index f4c1db2e7f548b7bbf313b80d5c56c4bf7f7c6b3..dcde38b39a821ed4877b81e5caf93f8aa1111e55 100644 (file)
@@ -1160,8 +1160,8 @@ static void ublk_dispatch_req(struct ublk_queue *ubq,
        struct ublk_io *io = &ubq->ios[tag];
        unsigned int mapped_bytes;
 
-       pr_devel("%s: complete: op %d, qid %d tag %d io_flags %x addr %llx\n",
-                       __func__, io->cmd->cmd_op, ubq->q_id, req->tag, io->flags,
+       pr_devel("%s: complete: qid %d tag %d io_flags %x addr %llx\n",
+                       __func__, ubq->q_id, req->tag, io->flags,
                        ublk_get_iod(ubq, req->tag)->addr);
 
        /*
@@ -1186,9 +1186,8 @@ static void ublk_dispatch_req(struct ublk_queue *ubq,
                 */
                if (!(io->flags & UBLK_IO_FLAG_NEED_GET_DATA)) {
                        io->flags |= UBLK_IO_FLAG_NEED_GET_DATA;
-                       pr_devel("%s: need get data. op %d, qid %d tag %d io_flags %x\n",
-                                       __func__, io->cmd->cmd_op, ubq->q_id,
-                                       req->tag, io->flags);
+                       pr_devel("%s: need get data. qid %d tag %d io_flags %x\n",
+                                       __func__, ubq->q_id, req->tag, io->flags);
                        ublk_complete_io_cmd(io, UBLK_IO_RES_NEED_GET_DATA,
                                             issue_flags);
                        return;
@@ -1201,8 +1200,8 @@ static void ublk_dispatch_req(struct ublk_queue *ubq,
                io->flags &= ~UBLK_IO_FLAG_NEED_GET_DATA;
                /* update iod->addr because ublksrv may have passed a new io buffer */
                ublk_get_iod(ubq, req->tag)->addr = io->addr;
-               pr_devel("%s: update iod->addr: op %d, qid %d tag %d io_flags %x addr %llx\n",
-                               __func__, io->cmd->cmd_op, ubq->q_id, req->tag, io->flags,
+               pr_devel("%s: update iod->addr: qid %d tag %d io_flags %x addr %llx\n",
+                               __func__, ubq->q_id, req->tag, io->flags,
                                ublk_get_iod(ubq, req->tag)->addr);
        }