ASoC: wm8962: Use the preferred form for passing a size of a struct
authorFabio Estevam <fabio.estevam@freescale.com>
Fri, 24 Oct 2014 15:01:26 +0000 (13:01 -0200)
committerMark Brown <broonie@kernel.org>
Tue, 28 Oct 2014 00:44:16 +0000 (00:44 +0000)
According to Documentation/CodingStyle - Chapter 14:

"The preferred form for passing a size of a struct is the following:

p = kmalloc(sizeof(*p), ...);

The alternative form where struct name is spelled out hurts readability and
introduces an opportunity for a bug when the pointer variable type is changed
but the corresponding sizeof that is passed to a memory allocator is not."

So do it as recommeded.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm8962.c

index 9077411e62ce5d3837ee4df65b1db6e48eda77dd..cfd38917acb81fd46016841000da79acf6b0faa5 100644 (file)
@@ -3552,8 +3552,7 @@ static int wm8962_i2c_probe(struct i2c_client *i2c,
        unsigned int reg;
        int ret, i, irq_pol, trigger;
 
-       wm8962 = devm_kzalloc(&i2c->dev, sizeof(struct wm8962_priv),
-                             GFP_KERNEL);
+       wm8962 = devm_kzalloc(&i2c->dev, sizeof(*wm8962), GFP_KERNEL);
        if (wm8962 == NULL)
                return -ENOMEM;