media: ar0521: Fix return value check in writing initial registers
authorSakari Ailus <sakari.ailus@linux.intel.com>
Tue, 30 Aug 2022 10:32:36 +0000 (12:32 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Sat, 24 Sep 2022 07:05:25 +0000 (09:05 +0200)
The return value from register writes is ignored apart from the last
value. Fix this.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/ar0521.c

index 9e90b02b15e3611c3264ad106835cd7110213613..a586e0fc0ea3f34d0063902c0f2fa88317bc4e2e 100644 (file)
@@ -755,11 +755,12 @@ static int ar0521_power_on(struct device *dev)
                gpiod_set_value(sensor->reset_gpio, 0);
        usleep_range(4500, 5000); /* min 45000 clocks */
 
-       for (cnt = 0; cnt < ARRAY_SIZE(initial_regs); cnt++)
+       for (cnt = 0; cnt < ARRAY_SIZE(initial_regs); cnt++) {
                ret = ar0521_write_regs(sensor, initial_regs[cnt].data,
                                        initial_regs[cnt].count);
                if (ret)
                        goto off;
+       }
 
        ret = ar0521_write_reg(sensor, AR0521_REG_SERIAL_FORMAT,
                               AR0521_REG_SERIAL_FORMAT_MIPI |