drm/msm/dpu: removed logically dead code

Fixed coverity warning by removing the dead code

Addresses-Coverity: 1494147 ("Logically dead code")

Signed-off-by: Ameer Hamza <amhamza.mgc@gmail.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20211203193253.108813-1-amhamza.mgc@gmail.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c
index 185379b185725837ed46eae32fe603627e2f4ec9..ddd9d89cd456a89fd5aff06277eda13d7a956eec 100644 (file)
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c
@@ -698,17 +698,17 @@ struct dpu_encoder_phys *dpu_encoder_phys_vid_init(
 {
        struct dpu_encoder_phys *phys_enc = NULL;
        struct dpu_encoder_irq *irq;
-       int i, ret = 0;
+       int i;
 
        if (!p) {
-               ret = -EINVAL;
-               goto fail;
+               DPU_ERROR("failed to create encoder due to invalid parameter\n");
+               return ERR_PTR(-EINVAL);
        }
 
        phys_enc = kzalloc(sizeof(*phys_enc), GFP_KERNEL);
        if (!phys_enc) {
-               ret = -ENOMEM;
-               goto fail;
+               DPU_ERROR("failed to create encoder due to memory allocation error\n");
+               return ERR_PTR(-ENOMEM);
        }
 
        phys_enc->hw_mdptop = p->dpu_kms->hw_mdp;
@@ -748,11 +748,4 @@ struct dpu_encoder_phys *dpu_encoder_phys_vid_init(
        DPU_DEBUG_VIDENC(phys_enc, "created intf idx:%d\n", p->intf_idx);
 
        return phys_enc;
-
-fail:
-       DPU_ERROR("failed to create encoder\n");
-       if (phys_enc)
-               dpu_encoder_phys_vid_destroy(phys_enc);
-
-       return ERR_PTR(ret);
 }