RDMA/core: Fix error return in _ib_modify_qp()
authorJing Xiangfeng <jingxiangfeng@huawei.com>
Fri, 16 Oct 2020 07:58:45 +0000 (15:58 +0800)
committerJason Gunthorpe <jgg@nvidia.com>
Wed, 28 Oct 2020 13:32:22 +0000 (10:32 -0300)
Fix to return error code PTR_ERR() from the error handling case instead of
0.

Fixes: 51aab12631dd ("RDMA/core: Get xmit slave for LAG")
Link: https://lore.kernel.org/r/20201016075845.129562-1-jingxiangfeng@huawei.com
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Reviewed-by: Maor Gottlieb <maorg@nvidia.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/core/verbs.c

index cfcfa3ae32cf21e9175f55eed09ae119860429a8..ab1e6048685ee5254e1128ac1a72153f7169f5ed 100644 (file)
@@ -1701,8 +1701,10 @@ static int _ib_modify_qp(struct ib_qp *qp, struct ib_qp_attr *attr,
                        slave = rdma_lag_get_ah_roce_slave(qp->device,
                                                           &attr->ah_attr,
                                                           GFP_KERNEL);
-                       if (IS_ERR(slave))
+                       if (IS_ERR(slave)) {
+                               ret = PTR_ERR(slave);
                                goto out_av;
+                       }
                        attr->xmit_slave = slave;
                }
        }