vhost/scsi: silence uninitialized variable warning
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 12 Jan 2017 18:45:04 +0000 (21:45 +0300)
committerMichael S. Tsirkin <mst@redhat.com>
Thu, 19 Jan 2017 21:46:30 +0000 (23:46 +0200)
This is to silence an uninitialized variable warning in debug output.
The problem is this line:

pr_debug("vhost_get_vq_desc: head: %d, out: %u in: %u\n",
 head, out, in);

If "head == vq->num" is true on the first iteration then "out" and "in"
aren't initialized.  We handle that a few lines after the printk.  I was
tempted to just delete the pr_debug() but I decided to just initialize
them to zero instead.

Also checkpatch.pl complains if variables are declared as just
"unsigned" without the "int".

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/vhost/scsi.c

index 620366dff7548e5af5d8582738e3bf2271cae0f4..fd6c8b66f06fd97734bfdad5917c7f65de70265d 100644 (file)
@@ -843,7 +843,7 @@ vhost_scsi_handle_vq(struct vhost_scsi *vs, struct vhost_virtqueue *vq)
        struct iov_iter out_iter, in_iter, prot_iter, data_iter;
        u64 tag;
        u32 exp_data_len, data_direction;
-       unsigned out, in;
+       unsigned int out = 0, in = 0;
        int head, ret, prot_bytes;
        size_t req_size, rsp_size = sizeof(struct virtio_scsi_cmd_resp);
        size_t out_size, in_size;