wireless: Remove call to memset after dma_alloc_coherent
authorFuqian Huang <huangfq.daxian@gmail.com>
Mon, 15 Jul 2019 03:19:41 +0000 (11:19 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 15 Oct 2019 05:20:16 +0000 (08:20 +0300)
In commit 518a2f1925c3
("dma-mapping: zero memory returned from dma_alloc_*"),
dma_alloc_coherent has already zeroed the memory.
So memset is not needed.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/ath10k/ce.c
drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c
drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c

index eca87f7c5b6c1e53f7f1c1921bf653af20e1f213..294fbc1e89ab8e33a538c496ceff8829ff1f9f84 100644 (file)
@@ -1704,9 +1704,6 @@ ath10k_ce_alloc_dest_ring_64(struct ath10k *ar, unsigned int ce_id,
        /* Correctly initialize memory to 0 to prevent garbage
         * data crashing system when download firmware
         */
-       memset(dest_ring->base_addr_owner_space_unaligned, 0,
-              nentries * sizeof(struct ce_desc_64) + CE_DESC_RING_ALIGN);
-
        dest_ring->base_addr_owner_space =
                        PTR_ALIGN(dest_ring->base_addr_owner_space_unaligned,
                                  CE_DESC_RING_ALIGN);
@@ -2019,8 +2016,6 @@ void ath10k_ce_alloc_rri(struct ath10k *ar)
                value |= ar->hw_ce_regs->upd->mask;
                ath10k_ce_write32(ar, ce_base_addr + ctrl1_regs, value);
        }
-
-       memset(ce->vaddr_rri, 0, CE_COUNT * sizeof(u32));
 }
 EXPORT_SYMBOL(ath10k_ce_alloc_rri);
 
index 6c463475e90b93b34419829fcd547256dfb63c08..3184dab41a5eb0b925af4ecac189cfdc98e3f777 100644 (file)
@@ -1024,8 +1024,6 @@ brcmf_pcie_init_dmabuffer_for_device(struct brcmf_pciedev_info *devinfo,
                               address & 0xffffffff);
        brcmf_pcie_write_tcm32(devinfo, tcm_dma_phys_addr + 4, address >> 32);
 
-       memset(ring, 0, size);
-
        return (ring);
 }
 
index 3aa3714d4dfd25a5c2cbd11fe88cb81b6c41f986..5ec1c9bc161293dc6009a50f9fcc0cc176fc44a1 100644 (file)
@@ -244,8 +244,6 @@ static int pearl_alloc_bd_table(struct qtnf_pcie_pearl_state *ps)
 
        /* tx bd */
 
-       memset(vaddr, 0, len);
-
        ps->bd_table_vaddr = vaddr;
        ps->bd_table_paddr = paddr;
        ps->bd_table_len = len;
index 9a4380ed7f1b214383b92dd3de405ef2e39aa930..1f91088e3dff2bebf3aa78c14e016785a7dba28c 100644 (file)
@@ -199,8 +199,6 @@ static int topaz_alloc_bd_table(struct qtnf_pcie_topaz_state *ts,
        if (!vaddr)
                return -ENOMEM;
 
-       memset(vaddr, 0, len);
-
        /* tx bd */
 
        ts->tx_bd_vbase = vaddr;