wifi: wilc1000: fix driver_handler when committing initial configuration
authorAjay Singh <ajay.kathat@microchip.com>
Mon, 15 Jan 2024 14:56:31 +0000 (15:56 +0100)
committerKalle Valo <kvalo@kernel.org>
Thu, 18 Jan 2024 09:35:14 +0000 (11:35 +0200)
During firmware initial configuration in wilc_init_fw_config, the special
driver_handler 0 should be used instead of targeting a specific virtual
interface (either 1 or 2)
The issue does not seem to have real consequence (both virtual interfaces
seems to answer correctly to a Add Block Ack request with the Immediate
policy), but lets make everything homogeneous

Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20240115-wilc_1000_fixes-v1-2-54d29463a738@bootlin.com
drivers/net/wireless/microchip/wilc1000/netdev.c

index 91d71e0f7ef2332354a0b950eea3e8795387ed7b..7ea538f2d6233489dce1b810e6e67364821ccde3 100644 (file)
@@ -416,7 +416,7 @@ static int wilc_init_fw_config(struct net_device *dev, struct wilc_vif *vif)
 
        b = 1;
        if (!wilc_wlan_cfg_set(vif, 0, WID_11N_IMMEDIATE_BA_ENABLED, &b, 1,
-                              1, 1))
+                              1, 0))
                goto fail;
 
        return 0;