habanalabs: replace some -ENOTTY with -EINVAL

-ENOTTY is returned in case of error in the ioctl arguments themselves,
such as function that doesn't exists.

In all other cases, where the error is in the arguments of the custom
data structures that we define that are passed in the various ioctls,
we need to return -EINVAL.

Signed-off-by: Oded Gabbay <ogabbay@kernel.org>

diff --git a/drivers/misc/habanalabs/common/command_buffer.c b/drivers/misc/habanalabs/common/command_buffer.c
index d4eb9fb9ea12036cff53128f2a841f4aeeaa61de..e7534b5129fa11a9055219667de487635a33392e 100644 (file)
--- a/drivers/misc/habanalabs/common/command_buffer.c
+++ b/drivers/misc/habanalabs/common/command_buffer.c
@@ -475,7 +475,7 @@ int hl_cb_ioctl(struct hl_fpriv *hpriv, void *data)
                break;
 
        default:
-               rc = -ENOTTY;
+               rc = -EINVAL;
                break;
        }
 

diff --git a/drivers/misc/habanalabs/common/habanalabs_ioctl.c b/drivers/misc/habanalabs/common/habanalabs_ioctl.c
index f571641c19ae1ecc9238a542caf47372d91e3b3c..7ddf70a0ca8a77be78de640aabc940fc11e66784 100644 (file)
--- a/drivers/misc/habanalabs/common/habanalabs_ioctl.c
+++ b/drivers/misc/habanalabs/common/habanalabs_ioctl.c
@@ -693,7 +693,7 @@ static int _hl_info_ioctl(struct hl_fpriv *hpriv, void *data,
 
        default:
                dev_err(dev, "Invalid request %d\n", args->op);
-               rc = -ENOTTY;
+               rc = -EINVAL;
                break;
        }
 
@@ -748,7 +748,7 @@ static int hl_debug_ioctl(struct hl_fpriv *hpriv, void *data)
 
        default:
                dev_err(hdev->dev, "Invalid request %d\n", args->op);
-               rc = -ENOTTY;
+               rc = -EINVAL;
                break;
        }
 

diff --git a/drivers/misc/habanalabs/common/memory.c b/drivers/misc/habanalabs/common/memory.c
index e5f7b23cbf94a5f5b45b2b19cb4d1abcc47930c4..b8596846f3dca4fefc8beaff1071d902cb7ee850 100644 (file)
--- a/drivers/misc/habanalabs/common/memory.c
+++ b/drivers/misc/habanalabs/common/memory.c
@@ -2031,7 +2031,7 @@ static int mem_ioctl_no_mmu(struct hl_fpriv *hpriv, union hl_mem_args *args)
 
        default:
                dev_err(hdev->dev, "Unknown opcode for memory IOCTL\n");
-               rc = -ENOTTY;
+               rc = -EINVAL;
                break;
        }
 
@@ -2156,7 +2156,7 @@ int hl_mem_ioctl(struct hl_fpriv *hpriv, void *data)
 
        default:
                dev_err(hdev->dev, "Unknown opcode for memory IOCTL\n");
-               rc = -ENOTTY;
+               rc = -EINVAL;
                break;
        }