drm/xe/bo: consider bo->flags in xe_bo_migrate()
authorMatthew Auld <matthew.auld@intel.com>
Mon, 19 Jun 2023 11:00:20 +0000 (12:00 +0100)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 21 Dec 2023 16:35:00 +0000 (11:35 -0500)
For VRAM allocations the bo->flags can control some characteristics of
the underlying memory, like whether it needs to be contiguous, and in
the future whether it needs to be in the CPU visible portion. Rather use
add_vram() in xe_bo_migrate() which should take care of such things for
us.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_bo.c

index ad0ea3014bfee6512f6617366a0d91931d42d814..f54fb7bd184a5022c91b11495edc01bc22f01f9c 100644 (file)
@@ -1852,6 +1852,7 @@ static void xe_place_from_ttm_type(u32 mem_type, struct ttm_place *place)
  */
 int xe_bo_migrate(struct xe_bo *bo, u32 mem_type)
 {
+       struct xe_device *xe = ttm_to_xe_device(bo->ttm.bdev);
        struct ttm_operation_ctx ctx = {
                .interruptible = true,
                .no_wait_gpu = false,
@@ -1876,6 +1877,18 @@ int xe_bo_migrate(struct xe_bo *bo, u32 mem_type)
        placement.placement = &requested;
        placement.busy_placement = &requested;
 
+       /*
+        * Stolen needs to be handled like below VRAM handling if we ever need
+        * to support it.
+        */
+       drm_WARN_ON(&xe->drm, mem_type == XE_PL_STOLEN);
+
+       if (mem_type_is_vram(mem_type)) {
+               u32 c = 0;
+
+               add_vram(xe, bo, &requested, bo->flags, mem_type, &c);
+       }
+
        return ttm_bo_validate(&bo->ttm, &placement, &ctx);
 }