xfs: stop using set_blocksize
authorDarrick J. Wong <djwong@kernel.org>
Wed, 23 Apr 2025 19:54:13 +0000 (12:54 -0700)
committerCarlos Maiolino <cem@kernel.org>
Mon, 28 Apr 2025 09:34:14 +0000 (11:34 +0200)
XFS has its own buffer cache for metadata that uses submit_bio, which
means that it no longer uses the block device pagecache for anything.
Create a more lightweight helper that runs the blocksize checks and
flushes dirty data and use that instead.  No more truncating the
pagecache because XFS does not use it or care about it.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
fs/xfs/xfs_buf.c

index 1a2b3f06fa717e893a14ff1c9ea3c7c7e127630b..5ae77ffdc947b1929d9fee33745f2c6443c58fb8 100644 (file)
@@ -1719,18 +1719,25 @@ xfs_setsize_buftarg(
        struct xfs_buftarg      *btp,
        unsigned int            sectorsize)
 {
+       int                     error;
+
        /* Set up metadata sector size info */
        btp->bt_meta_sectorsize = sectorsize;
        btp->bt_meta_sectormask = sectorsize - 1;
 
-       if (set_blocksize(btp->bt_bdev_file, sectorsize)) {
+       error = bdev_validate_blocksize(btp->bt_bdev, sectorsize);
+       if (error) {
                xfs_warn(btp->bt_mount,
-                       "Cannot set_blocksize to %u on device %pg",
-                       sectorsize, btp->bt_bdev);
+                       "Cannot use blocksize %u on device %pg, err %d",
+                       sectorsize, btp->bt_bdev, error);
                return -EINVAL;
        }
 
-       return 0;
+       /*
+        * Flush the block device pagecache so our bios see anything dirtied
+        * before mount.
+        */
+       return sync_blockdev(btp->bt_bdev);
 }
 
 int