nfsd4: remove check_conflicting_opens warning
authorJ. Bruce Fields <bfields@redhat.com>
Fri, 25 Sep 2020 14:09:58 +0000 (10:09 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Fri, 25 Sep 2020 22:02:02 +0000 (18:02 -0400)
There are actually rare races where this is possible (e.g. if a new open
intervenes between the read of i_writecount and the fi_fds).

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4state.c

index 726046b6b370af0e64d6abfcff7c41cc206a7814..a59551efd263e0e8e24ae788f18ba68ad84eff26 100644 (file)
@@ -4955,7 +4955,6 @@ static int nfsd4_check_conflicting_opens(struct nfs4_client *clp,
                writes--;
        if (fp->fi_fds[O_RDWR])
                writes--;
-       WARN_ON_ONCE(writes < 0);
        if (writes > 0)
                return -EAGAIN;
        spin_lock(&fp->fi_lock);