selftests/powerpc: Fix out of bounds access in TM signal test
authorMichael Ellerman <mpe@ellerman.id.au>
Wed, 2 Mar 2016 12:28:54 +0000 (23:28 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 2 Mar 2016 12:34:45 +0000 (23:34 +1100)
Gcc helpfully points out that we're accessing past the end of the gprs
array:

  tm-signal-msr-resv.c: In function 'signal_usr1':
  tm-signal-msr-resv.c:43:37: error: array subscript is above array bounds [-Werror=array-bounds]
    ucp->uc_mcontext.regs->gpr[PT_MSR] |= (7ULL);

We haven't noticed previously because -flto was hiding it somehow.

The code is confused, PT_MSR isn't a gpr, instead it's in
uc_regs->gregs, so fix it.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
tools/testing/selftests/powerpc/tm/tm-signal-msr-resv.c

index d86653f282b148e0ed6283b7815127bdf32005e0..8c54d18b3e9ac244cc7441adafbd99774566021a 100644 (file)
@@ -40,7 +40,7 @@ void signal_usr1(int signum, siginfo_t *info, void *uc)
 #ifdef __powerpc64__
        ucp->uc_mcontext.gp_regs[PT_MSR] |= (7ULL << 32);
 #else
-       ucp->uc_mcontext.regs->gpr[PT_MSR] |= (7ULL);
+       ucp->uc_mcontext.uc_regs->gregs[PT_MSR] |= (7ULL);
 #endif
        /* Should segv on return becuase of invalid context */
        segv_expected = 1;