media: rkisp1: isp: Add the enum_frame_size ioctl
authorSebastian Fricke <sebastian.fricke.linux@gmail.com>
Sat, 12 Dec 2020 18:53:06 +0000 (19:53 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 12 Jan 2021 17:16:41 +0000 (18:16 +0100)
Implement the VIDIOC_SUBDEV_ENUM_FRAME_SIZE ioctl for the isp entity,
check if the mbus code is valid for the given pad.
This call is not available for the parameter or metadata pads of the
RkISP1.

Signed-off-by: Sebastian Fricke <sebastian.fricke.linux@gmail.com>
Acked-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Acked-by: Helen Koike <helen.koike@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c

index 889982d8ca41d1763a57ac5247f46deb90fe65e6..2e5b57e3aedc91c2c2aab9443a4a9181b3173dc0 100644 (file)
@@ -600,6 +600,39 @@ static int rkisp1_isp_enum_mbus_code(struct v4l2_subdev *sd,
        return -EINVAL;
 }
 
+static int rkisp1_isp_enum_frame_size(struct v4l2_subdev *sd,
+                                     struct v4l2_subdev_pad_config *cfg,
+                                     struct v4l2_subdev_frame_size_enum *fse)
+{
+       const struct rkisp1_isp_mbus_info *mbus_info;
+
+       if (fse->pad == RKISP1_ISP_PAD_SINK_PARAMS ||
+           fse->pad == RKISP1_ISP_PAD_SOURCE_STATS)
+               return -ENOTTY;
+
+       if (fse->index > 0)
+               return -EINVAL;
+
+       mbus_info = rkisp1_isp_mbus_info_get(fse->code);
+       if (!mbus_info)
+               return -EINVAL;
+
+       if (!(mbus_info->direction & RKISP1_ISP_SD_SINK) &&
+           fse->pad == RKISP1_ISP_PAD_SINK_VIDEO)
+               return -EINVAL;
+
+       if (!(mbus_info->direction & RKISP1_ISP_SD_SRC) &&
+           fse->pad == RKISP1_ISP_PAD_SOURCE_VIDEO)
+               return -EINVAL;
+
+       fse->min_width = RKISP1_ISP_MIN_WIDTH;
+       fse->max_width = RKISP1_ISP_MAX_WIDTH;
+       fse->min_height = RKISP1_ISP_MIN_HEIGHT;
+       fse->max_height = RKISP1_ISP_MAX_HEIGHT;
+
+       return 0;
+}
+
 static int rkisp1_isp_init_config(struct v4l2_subdev *sd,
                                  struct v4l2_subdev_pad_config *cfg)
 {
@@ -880,6 +913,7 @@ static int rkisp1_subdev_link_validate(struct media_link *link)
 
 static const struct v4l2_subdev_pad_ops rkisp1_isp_pad_ops = {
        .enum_mbus_code = rkisp1_isp_enum_mbus_code,
+       .enum_frame_size = rkisp1_isp_enum_frame_size,
        .get_selection = rkisp1_isp_get_selection,
        .set_selection = rkisp1_isp_set_selection,
        .init_cfg = rkisp1_isp_init_config,