ASoC: sh: rz-ssi: Drop ssi parameter from rz_ssi_stream_init()
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Mon, 10 Jan 2022 09:47:09 +0000 (09:47 +0000)
committerMark Brown <broonie@kernel.org>
Mon, 24 Jan 2022 13:31:30 +0000 (13:31 +0000)
ssi parameter is unused in rz_ssi_stream_init() so just drop it.

While at it, change the return type of rz_ssi_stream_init() to void
instead of int.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Link: https://lore.kernel.org/r/20220110094711.8574-4-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sh/rz-ssi.c

index 7379b1489e358b8decff64a17a8818331d4c31fb..cbd8e1f3ac2e0c6f756b612336b8e43d917b10d2 100644 (file)
@@ -201,9 +201,8 @@ static int rz_ssi_stream_is_valid(struct rz_ssi_priv *ssi,
        return ret;
 }
 
-static int rz_ssi_stream_init(struct rz_ssi_priv *ssi,
-                             struct rz_ssi_stream *strm,
-                             struct snd_pcm_substream *substream)
+static void rz_ssi_stream_init(struct rz_ssi_stream *strm,
+                              struct snd_pcm_substream *substream)
 {
        struct snd_pcm_runtime *runtime = substream->runtime;
 
@@ -219,8 +218,6 @@ static int rz_ssi_stream_init(struct rz_ssi_priv *ssi,
 
        /* fifo init */
        strm->fifo_sample_size = SSI_FIFO_DEPTH;
-
-       return 0;
 }
 
 static void rz_ssi_stream_quit(struct rz_ssi_priv *ssi,
@@ -728,9 +725,7 @@ static int rz_ssi_dai_trigger(struct snd_pcm_substream *substream, int cmd,
                rz_ssi_reg_mask_setl(ssi, SSIFCR, SSIFCR_SSIRST, 0);
                udelay(5);
 
-               ret = rz_ssi_stream_init(ssi, strm, substream);
-               if (ret)
-                       goto done;
+               rz_ssi_stream_init(strm, substream);
 
                if (ssi->dma_rt) {
                        bool is_playback;