drm/xe: Fix potential integer overflow in page size calculation
authorNirmoy Das <nirmoy.das@intel.com>
Mon, 18 Mar 2024 16:43:41 +0000 (17:43 +0100)
committerMatthew Auld <matthew.auld@intel.com>
Tue, 19 Mar 2024 08:33:42 +0000 (08:33 +0000)
Explicitly cast tbo->page_alignment to u64 before bit-shifting to
prevent overflow when assigning to min_page_size.

Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240318164342.3094-1-nirmoy.das@intel.com
drivers/gpu/drm/xe/xe_ttm_vram_mgr.c

index 115ec745e50294b0f8cc3752f44d34af3f9fa066..0678faf832126cf199339a0cc1a7ea373571d36d 100644 (file)
@@ -91,7 +91,7 @@ static int xe_ttm_vram_mgr_new(struct ttm_resource_manager *man,
 
        min_page_size = mgr->default_page_size;
        if (tbo->page_alignment)
-               min_page_size = tbo->page_alignment << PAGE_SHIFT;
+               min_page_size = (u64)tbo->page_alignment << PAGE_SHIFT;
 
        if (WARN_ON(min_page_size < mm->chunk_size)) {
                err = -EINVAL;