scsi: pm8001: Remove unnecessary OOM message
authorZhen Lei <thunder.leizhen@huawei.com>
Thu, 10 Jun 2021 09:46:05 +0000 (17:46 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 16 Jun 2021 02:41:12 +0000 (22:41 -0400)
Fixes scripts/checkpatch.pl warning:
WARNING: Possible unnecessary 'out of memory' message

Remove it can help us save a bit of memory.

Also change the return error code from "-1" to "-ENOMEM".

Link: https://lore.kernel.org/r/20210610094605.16672-2-thunder.leizhen@huawei.com
Acked-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/pm8001/pm8001_sas.c

index 01122993c943fdb2023c199087b5692fe1da8838..d63c7d59ad3457d6c669f692e0db854a7490f839 100644 (file)
@@ -118,10 +118,8 @@ int pm8001_mem_alloc(struct pci_dev *pdev, void **virt_addr,
                align_offset = (dma_addr_t)align - 1;
        mem_virt_alloc = dma_alloc_coherent(&pdev->dev, mem_size + align,
                                            &mem_dma_handle, GFP_KERNEL);
-       if (!mem_virt_alloc) {
-               pr_err("pm80xx: memory allocation error\n");
-               return -1;
-       }
+       if (!mem_virt_alloc)
+               return -ENOMEM;
        *pphys_addr = mem_dma_handle;
        phys_align = (*pphys_addr + align_offset) & ~align_offset;
        *virt_addr = (void *)mem_virt_alloc + phys_align - *pphys_addr;