KVM: s390: fix fallthrough annotation
authorSebastian Ott <sebott@linux.vnet.ibm.com>
Mon, 29 Jan 2018 15:12:30 +0000 (16:12 +0100)
committerChristian Borntraeger <borntraeger@de.ibm.com>
Wed, 14 Mar 2018 19:21:16 +0000 (19:21 +0000)
A case statement in kvm_s390_shadow_tables uses fallthrough annotations
which are not recognized by gcc because they are hidden within a block.
Move these annotations out of the block to fix (W=1) warnings like below:

arch/s390/kvm/gaccess.c: In function 'kvm_s390_shadow_tables':
arch/s390/kvm/gaccess.c:1029:26: warning: this statement may fall through [-Wimplicit-fallthrough=]
  case ASCE_TYPE_REGION1: {
                          ^

Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
arch/s390/kvm/gaccess.c

index c24bfa72baf79c95f7c37124d9ed2cdd4c9de33b..8e2b8647ee124b3253cd71f75d35f8623f97d5c8 100644 (file)
@@ -1050,8 +1050,7 @@ shadow_r2t:
                rc = gmap_shadow_r2t(sg, saddr, rfte.val, *fake);
                if (rc)
                        return rc;
-               /* fallthrough */
-       }
+       } /* fallthrough */
        case ASCE_TYPE_REGION2: {
                union region2_table_entry rste;
 
@@ -1077,8 +1076,7 @@ shadow_r3t:
                rc = gmap_shadow_r3t(sg, saddr, rste.val, *fake);
                if (rc)
                        return rc;
-               /* fallthrough */
-       }
+       } /* fallthrough */
        case ASCE_TYPE_REGION3: {
                union region3_table_entry rtte;
 
@@ -1113,8 +1111,7 @@ shadow_sgt:
                rc = gmap_shadow_sgt(sg, saddr, rtte.val, *fake);
                if (rc)
                        return rc;
-               /* fallthrough */
-       }
+       } /* fallthrough */
        case ASCE_TYPE_SEGMENT: {
                union segment_table_entry ste;