crypto: stm32/cryp - Fix PM reference leak on stm32-cryp.c
authorShixin Liu <liushixin2@huawei.com>
Thu, 8 Apr 2021 07:18:36 +0000 (15:18 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 May 2021 12:47:21 +0000 (14:47 +0200)
[ Upstream commit 747bf30fd944f02f341b5f3bc7d97a13f2ae2fbe ]

pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Signed-off-by: Shixin Liu <liushixin2@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/crypto/stm32/stm32-cryp.c

index 2670c30332fad9f3638d831607c9790f2966562a..7999b26a16ed057217a570cfe780c29d0d5a229c 100644 (file)
@@ -542,7 +542,7 @@ static int stm32_cryp_hw_init(struct stm32_cryp *cryp)
        int ret;
        u32 cfg, hw_mode;
 
-       pm_runtime_get_sync(cryp->dev);
+       pm_runtime_resume_and_get(cryp->dev);
 
        /* Disable interrupt */
        stm32_cryp_write(cryp, CRYP_IMSCR, 0);
@@ -2043,7 +2043,7 @@ static int stm32_cryp_remove(struct platform_device *pdev)
        if (!cryp)
                return -ENODEV;
 
-       ret = pm_runtime_get_sync(cryp->dev);
+       ret = pm_runtime_resume_and_get(cryp->dev);
        if (ret < 0)
                return ret;