pwm: bcm2835: Fix NPD in suspend/resume
authorFlorian Fainelli <florian.fainelli@broadcom.com>
Mon, 13 Nov 2023 16:46:32 +0000 (08:46 -0800)
committerUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 21 Nov 2023 10:09:32 +0000 (11:09 +0100)
When 119a508c4dc9 ("pwm: bcm2835: Add support for suspend/resume") was
sent out on October 11th,, there was still a call to
platform_set_drvdata() which would ensure that the driver private data
structure could be used in bcm2835_pwm_{suspend,resume}.

A cleanup now merged as commit commit 2ce7b7f6704c ("pwm: bcm2835:
Simplify using devm functions") removed that call which would now cause
a NPD in bcm2835_pwm_{suspend,resume} as a consequence.

Fixes: 119a508c4dc9 ("pwm: bcm2835: Add support for suspend/resume")
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/linux-pwm/20231113164632.2439400-1-florian.fainelli@broadcom.com
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
drivers/pwm/pwm-bcm2835.c

index 9777babd5b95cd9fc3a4388745840ab1a7e2bbdc..ab30667f4f951c0d46ccbeddf365437652c269ba 100644 (file)
@@ -155,6 +155,8 @@ static int bcm2835_pwm_probe(struct platform_device *pdev)
        pc->chip.ops = &bcm2835_pwm_ops;
        pc->chip.npwm = 2;
 
+       platform_set_drvdata(pdev, pc);
+
        ret = devm_pwmchip_add(&pdev->dev, &pc->chip);
        if (ret < 0)
                return dev_err_probe(&pdev->dev, ret,