media: i2c: adv7842: make array cri static and const, makes object smaller
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 11 Oct 2019 20:48:29 +0000 (17:48 -0300)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Thu, 24 Oct 2019 21:33:18 +0000 (18:33 -0300)
Don't populate the array 'cri' on the stack but instead make it
static and const. Makes the object code smaller by 165 bytes.

Turn the 2nd parameter of 'log_infoframe()' const accordingly.

Before:
   text    data     bss     dec     hex filename
  98533   20024     256  118813   1d01d drivers/media/i2c/adv7842.o

After:
   text    data     bss     dec     hex filename
  98304   20088     256  118648   1cf78 drivers/media/i2c/adv7842.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/i2c/adv7842.c

index 885619841719b390b1180b5a5fddca0ed2cea0dd..0855f648416d1d2fcf511efe9afec582235781aa 100644 (file)
@@ -2547,7 +2547,7 @@ struct adv7842_cfg_read_infoframe {
        u8 payload_addr;
 };
 
-static void log_infoframe(struct v4l2_subdev *sd, struct adv7842_cfg_read_infoframe *cri)
+static void log_infoframe(struct v4l2_subdev *sd, const struct adv7842_cfg_read_infoframe *cri)
 {
        int i;
        u8 buffer[32];
@@ -2585,7 +2585,7 @@ static void log_infoframe(struct v4l2_subdev *sd, struct adv7842_cfg_read_infofr
 static void adv7842_log_infoframes(struct v4l2_subdev *sd)
 {
        int i;
-       struct adv7842_cfg_read_infoframe cri[] = {
+       static const struct adv7842_cfg_read_infoframe cri[] = {
                { "AVI", 0x01, 0xe0, 0x00 },
                { "Audio", 0x02, 0xe3, 0x1c },
                { "SDP", 0x04, 0xe6, 0x2a },