drm/bridge: ti-sn65dsi83: use dev_err_probe when failing to get panel bridge
authorLuca Ceresoli <luca.ceresoli@bootlin.com>
Tue, 17 Dec 2024 16:02:51 +0000 (17:02 +0100)
committerNeil Armstrong <neil.armstrong@linaro.org>
Wed, 18 Dec 2024 10:14:06 +0000 (11:14 +0100)
When devm_drm_of_get_bridge() fails, the probe fails silently. Use
dev_err_probe() instead to log an error or report the deferral reason,
whichever is applicable.

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Link: https://lore.kernel.org/r/20241217-ti-sn65dsi83-dev_err_probe-v1-1-3fdce386400c@bootlin.com
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20241217-ti-sn65dsi83-dev_err_probe-v1-1-3fdce386400c@bootlin.com
drivers/gpu/drm/bridge/ti-sn65dsi83.c

index 00d3bfa645f5a3435f11fc42c348a742410c62b2..e4a8e6472341a8cf21358058fa3f16c9fa682b9b 100644 (file)
@@ -606,7 +606,7 @@ static int sn65dsi83_parse_dt(struct sn65dsi83 *ctx, enum sn65dsi83_model model)
 
        panel_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 2, 0);
        if (IS_ERR(panel_bridge))
-               return PTR_ERR(panel_bridge);
+               return dev_err_probe(dev, PTR_ERR(panel_bridge), "Failed to get panel bridge\n");
 
        ctx->panel_bridge = panel_bridge;