nfsd: use correct format characters
authorBill Wendling <morbo@google.com>
Thu, 17 Mar 2022 18:42:22 +0000 (11:42 -0700)
committerChuck Lever <chuck.lever@oracle.com>
Thu, 17 Mar 2022 23:47:38 +0000 (19:47 -0400)
When compiling with -Wformat, clang emits the following warnings:

fs/nfsd/flexfilelayout.c:120:27: warning: format specifies type 'unsigned
char' but the argument has type 'int' [-Wformat]
                         "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
                             ~~~~              ^~~~~~~~~
                             %d
fs/nfsd/flexfilelayout.c:120:38: warning: format specifies type 'unsigned
char' but the argument has type 'int' [-Wformat]
                         "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
                                  ~~~~                    ^~~~~~~~~~~
                                  %d

The types of these arguments are unconditionally defined, so this patch
updates the format character to the correct ones for ints and unsigned
ints.

Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Bill Wendling <morbo@google.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: Tom Haynes <loghyr@hammerspace.com>
fs/nfsd/flexfilelayout.c

index 2e2f1d5e9f623cf25cad07e0dfba768f60d6e431..070f90ed09b61336394a2d903bfedcdaa77de341 100644 (file)
@@ -117,7 +117,7 @@ nfsd4_ff_proc_getdeviceinfo(struct super_block *sb, struct svc_rqst *rqstp,
 
        da->netaddr.addr_len =
                snprintf(da->netaddr.addr, FF_ADDR_LEN + 1,
-                        "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
+                        "%s.%d.%d", addr, port >> 8, port & 0xff);
 
        da->tightly_coupled = false;