bcachefs: Fix an in iterator leak

This should fix a transaction iterator overflow bug during fsck.

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

diff --git a/fs/bcachefs/str_hash.h b/fs/bcachefs/str_hash.h
index 35f4232d07554e40c6106c096a3f79c6a58f1b42..cf6ecd963a7bec793d49299a6d465c5179679879 100644 (file)
--- a/fs/bcachefs/str_hash.h
+++ b/fs/bcachefs/str_hash.h
@@ -319,13 +319,16 @@ int bch2_hash_delete(struct btree_trans *trans,
                     u64 inode, const void *key)
 {
        struct btree_iter *iter;
+       int ret;
 
        iter = bch2_hash_lookup(trans, desc, info, inode, key,
                                BTREE_ITER_INTENT);
        if (IS_ERR(iter))
                return PTR_ERR(iter);
 
-       return bch2_hash_delete_at(trans, desc, info, iter);
+       ret = bch2_hash_delete_at(trans, desc, info, iter);
+       bch2_trans_iter_put(trans, iter);
+       return ret;
 }
 
 #endif /* _BCACHEFS_STR_HASH_H */