tracing: Fix synth event printk format for str fields
authorDouglas Raillard <douglas.raillard@arm.com>
Tue, 25 Mar 2025 16:52:02 +0000 (16:52 +0000)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Tue, 25 Mar 2025 21:42:38 +0000 (17:42 -0400)
The printk format for synth event uses "%.*s" to print string fields,
but then only passes the pointer part as var arg.

Replace %.*s with %s as the C string is guaranteed to be null-terminated.

The output in print fmt should never have been updated as __get_str()
handles the string limit because it can access the length of the string in
the string meta data that is saved in the ring buffer.

Cc: stable@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Fixes: 8db4d6bfbbf92 ("tracing: Change synthetic event string format to limit printed length")
Link: https://lore.kernel.org/20250325165202.541088-1-douglas.raillard@arm.com
Signed-off-by: Douglas Raillard <douglas.raillard@arm.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace_events_synth.c

index a5c5f34c207a6f495274c21d5398456c3b27f7fa..6d592cbc38e4f5462b2ee6be743d3def94850aae 100644 (file)
@@ -305,7 +305,7 @@ static const char *synth_field_fmt(char *type)
        else if (strcmp(type, "gfp_t") == 0)
                fmt = "%x";
        else if (synth_field_is_string(type))
-               fmt = "%.*s";
+               fmt = "%s";
        else if (synth_field_is_stack(type))
                fmt = "%s";