HID: lg-g15: make a const array static, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Thu, 4 Feb 2021 17:27:48 +0000 (17:27 +0000)
committerJiri Kosina <jkosina@suse.cz>
Fri, 5 Feb 2021 09:13:28 +0000 (10:13 +0100)
Don't populate the const array led_names on the stack but instead make
it static. Makes the object code smaller by 79 bytes:

Before:
   text    data     bss     dec     hex filename
  19686    7952     256   27894    6cf6 drivers/hid/hid-lg-g15.o

After:
   text    data     bss     dec     hex filename
  19543    8016     256   27815    6ca7 drivers/hid/hid-lg-g15.o

(gcc version 10.2.0)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-lg-g15.c

index fcaf8466e627d51da31c781bbbc2f820c80b405d..bfbba0d4193315cc0073beb2782688fd016ec041 100644 (file)
@@ -647,7 +647,7 @@ static void lg_g15_input_close(struct input_dev *dev)
 
 static int lg_g15_register_led(struct lg_g15_data *g15, int i)
 {
-       const char * const led_names[] = {
+       static const char * const led_names[] = {
                "g15::kbd_backlight",
                "g15::lcd_backlight",
                "g15::macro_preset1",