ipv6: ah6: use swap() to make code cleaner

Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Yao Jing <yao.jing2@zte.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/ipv6/ah6.c b/net/ipv6/ah6.c
index 828e62514260aff851e016fe7ca095f005f89a0f..b5995c1f4d7a50dd2f8766304f2bb4a4ae4f2358 100644 (file)
--- a/net/ipv6/ah6.c
+++ b/net/ipv6/ah6.c
@@ -175,7 +175,6 @@ static void ipv6_rearrange_destopt(struct ipv6hdr *iph, struct ipv6_opt_hdr *des
                         * See 11.3.2 of RFC 3775 for details.
                         */
                        if (opt[off] == IPV6_TLV_HAO) {
-                               struct in6_addr final_addr;
                                struct ipv6_destopt_hao *hao;
 
                                hao = (struct ipv6_destopt_hao *)&opt[off];
@@ -184,9 +183,7 @@ static void ipv6_rearrange_destopt(struct ipv6hdr *iph, struct ipv6_opt_hdr *des
                                                             hao->length);
                                        goto bad;
                                }
-                               final_addr = hao->addr;
-                               hao->addr = iph->saddr;
-                               iph->saddr = final_addr;
+                               swap(hao->addr, iph->saddr);
                        }
                        break;
                }