nouveau/svm: Split assignment from if conditional
authorGustavo A. R. Silva <gustavoars@kernel.org>
Wed, 16 Aug 2023 18:05:06 +0000 (12:05 -0600)
committerKees Cook <keescook@chromium.org>
Fri, 29 Sep 2023 18:19:43 +0000 (11:19 -0700)
Fix checkpatch.pl ERROR: do not use assignment in if condition.

Signed-off-by: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/6b900e80b5587187c68efc788f5b042ca747d374.1692208802.git.gustavoars@kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
drivers/gpu/drm/nouveau/nouveau_svm.c

index 00444ad82d18388dc060d39448d5a8166a6ee14d..cc03e0c22ff3fec65cf6a40ae34db2af20bb349e 100644 (file)
@@ -1063,7 +1063,8 @@ nouveau_svm_init(struct nouveau_drm *drm)
        if (drm->client.device.info.family > NV_DEVICE_INFO_V0_PASCAL)
                return;
 
-       if (!(drm->svm = svm = kzalloc(struct_size(drm->svm, buffer, 1), GFP_KERNEL)))
+       drm->svm = svm = kzalloc(struct_size(drm->svm, buffer, 1), GFP_KERNEL);
+       if (!drm->svm)
                return;
 
        drm->svm->drm = drm;