vdpa/mlx5: Drop redundant code
authorDragos Tatulea <dtatulea@nvidia.com>
Wed, 26 Jun 2024 10:26:39 +0000 (13:26 +0300)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 9 Jul 2024 12:42:43 +0000 (08:42 -0400)
Originally, the second loop initialized the CVQ. But (acde3929492b
("vdpa/mlx5: Use consistent RQT size") initialized all the queues in the
first loop, so the second iteration in init_mvqs() is never called
because the first one will iterate up to max_vqs.

Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>
Acked-by: Eugenio Pérez <eperezma@redhat.com>
Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
Message-Id: <20240626-stage-vdpa-vq-precreate-v2-3-560c491078df@nvidia.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/vdpa/mlx5/net/mlx5_vnet.c

index 1ad281cbc541694b5a0165ee66e70a80412dc377..b4d9ef4f66c805c4de394a66129fdb1dcfd6234f 100644 (file)
@@ -3519,12 +3519,6 @@ static void init_mvqs(struct mlx5_vdpa_net *ndev)
                mvq->fwqp.fw = true;
                mvq->fw_state = MLX5_VIRTIO_NET_Q_OBJECT_NONE;
        }
-       for (; i < ndev->mvdev.max_vqs; i++) {
-               mvq = &ndev->vqs[i];
-               memset(mvq, 0, offsetof(struct mlx5_vdpa_virtqueue, ri));
-               mvq->index = i;
-               mvq->ndev = ndev;
-       }
 }
 
 struct mlx5_vdpa_mgmtdev {