drm/amd/pm/smu13: Remove unused smu_v3 functions
authorDr. David Alan Gilbert <linux@treblig.org>
Wed, 7 May 2025 00:24:25 +0000 (01:24 +0100)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 7 May 2025 21:46:42 +0000 (17:46 -0400)
smu_v13_0_display_clock_voltage_request() and
smu_v13_0_set_min_deep_sleep_dcefclk() were added in 2020 by
commit c05d1c401572 ("drm/amd/swsmu: add aldebaran smu13 ip support (v3)")
but have remained unused.

Remove them.

smu_v13_0_display_clock_voltage_request() was the only user
of smu_v13_0_set_hard_freq_limited_range().  Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c

index 9678d2593f8f70e4bb23d74c6ce3646fe7287c3e..c22ed28c0cdbe928603ea8c1366ba8217f2d524a 100644 (file)
@@ -184,13 +184,6 @@ int smu_v13_0_disable_thermal_alert(struct smu_context *smu);
 
 int smu_v13_0_get_gfx_vdd(struct smu_context *smu, uint32_t *value);
 
-int smu_v13_0_set_min_deep_sleep_dcefclk(struct smu_context *smu, uint32_t clk);
-
-int
-smu_v13_0_display_clock_voltage_request(struct smu_context *smu,
-                                       struct pp_display_clock_request
-                                       *clock_req);
-
 uint32_t
 smu_v13_0_get_fan_control_mode(struct smu_context *smu);
 
@@ -227,11 +220,6 @@ int smu_v13_0_get_dpm_ultimate_freq(struct smu_context *smu, enum smu_clk_type c
 int smu_v13_0_set_soft_freq_limited_range(struct smu_context *smu, enum smu_clk_type clk_type,
                                          uint32_t min, uint32_t max, bool automatic);
 
-int smu_v13_0_set_hard_freq_limited_range(struct smu_context *smu,
-                                         enum smu_clk_type clk_type,
-                                         uint32_t min,
-                                         uint32_t max);
-
 int smu_v13_0_set_performance_level(struct smu_context *smu,
                                    enum amd_dpm_forced_level level);
 
index 075f381ad311ba7740a54a31d0d507d3488c19cf..45b5ab4238449d8e118fc49236024e7ed13144ec 100644 (file)
@@ -709,18 +709,6 @@ int smu_v13_0_notify_memory_pool_location(struct smu_context *smu)
        return ret;
 }
 
-int smu_v13_0_set_min_deep_sleep_dcefclk(struct smu_context *smu, uint32_t clk)
-{
-       int ret;
-
-       ret = smu_cmn_send_smc_msg_with_param(smu,
-                                             SMU_MSG_SetMinDeepSleepDcefclk, clk, NULL);
-       if (ret)
-               dev_err(smu->adev->dev, "SMU13 attempt to set divider for DCEFCLK Failed!");
-
-       return ret;
-}
-
 int smu_v13_0_set_driver_table_location(struct smu_context *smu)
 {
        struct smu_table *driver_table = &smu->smu_table.driver_table;
@@ -1073,56 +1061,6 @@ int smu_v13_0_get_gfx_vdd(struct smu_context *smu, uint32_t *value)
 
 }
 
-int
-smu_v13_0_display_clock_voltage_request(struct smu_context *smu,
-                                       struct pp_display_clock_request
-                                       *clock_req)
-{
-       enum amd_pp_clock_type clk_type = clock_req->clock_type;
-       int ret = 0;
-       enum smu_clk_type clk_select = 0;
-       uint32_t clk_freq = clock_req->clock_freq_in_khz / 1000;
-
-       if (smu_cmn_feature_is_enabled(smu, SMU_FEATURE_DPM_DCEFCLK_BIT) ||
-           smu_cmn_feature_is_enabled(smu, SMU_FEATURE_DPM_UCLK_BIT)) {
-               switch (clk_type) {
-               case amd_pp_dcef_clock:
-                       clk_select = SMU_DCEFCLK;
-                       break;
-               case amd_pp_disp_clock:
-                       clk_select = SMU_DISPCLK;
-                       break;
-               case amd_pp_pixel_clock:
-                       clk_select = SMU_PIXCLK;
-                       break;
-               case amd_pp_phy_clock:
-                       clk_select = SMU_PHYCLK;
-                       break;
-               case amd_pp_mem_clock:
-                       clk_select = SMU_UCLK;
-                       break;
-               default:
-                       dev_info(smu->adev->dev, "[%s] Invalid Clock Type!", __func__);
-                       ret = -EINVAL;
-                       break;
-               }
-
-               if (ret)
-                       goto failed;
-
-               if (clk_select == SMU_UCLK && smu->disable_uclk_switch)
-                       return 0;
-
-               ret = smu_v13_0_set_hard_freq_limited_range(smu, clk_select, clk_freq, 0);
-
-               if (clk_select == SMU_UCLK)
-                       smu->hard_min_uclk_req_from_dal = clk_freq;
-       }
-
-failed:
-       return ret;
-}
-
 uint32_t smu_v13_0_get_fan_control_mode(struct smu_context *smu)
 {
        if (!smu_cmn_feature_is_enabled(smu, SMU_FEATURE_FAN_CONTROL_BIT))
@@ -1647,45 +1585,6 @@ out:
        return ret;
 }
 
-int smu_v13_0_set_hard_freq_limited_range(struct smu_context *smu,
-                                         enum smu_clk_type clk_type,
-                                         uint32_t min,
-                                         uint32_t max)
-{
-       int ret = 0, clk_id = 0;
-       uint32_t param;
-
-       if (min <= 0 && max <= 0)
-               return -EINVAL;
-
-       if (!smu_cmn_clk_dpm_is_enabled(smu, clk_type))
-               return 0;
-
-       clk_id = smu_cmn_to_asic_specific_index(smu,
-                                               CMN2ASIC_MAPPING_CLK,
-                                               clk_type);
-       if (clk_id < 0)
-               return clk_id;
-
-       if (max > 0) {
-               param = (uint32_t)((clk_id << 16) | (max & 0xffff));
-               ret = smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_SetHardMaxByFreq,
-                                                     param, NULL);
-               if (ret)
-                       return ret;
-       }
-
-       if (min > 0) {
-               param = (uint32_t)((clk_id << 16) | (min & 0xffff));
-               ret = smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_SetHardMinByFreq,
-                                                     param, NULL);
-               if (ret)
-                       return ret;
-       }
-
-       return ret;
-}
-
 int smu_v13_0_set_performance_level(struct smu_context *smu,
                                    enum amd_dpm_forced_level level)
 {