octeontx2-af: cn10kb: fix interrupt csr addresses
authorHariprasad Kelam <hkelam@marvell.com>
Fri, 30 Jun 2023 06:28:42 +0000 (11:58 +0530)
committerDavid S. Miller <davem@davemloft.net>
Sun, 2 Jul 2023 14:47:18 +0000 (15:47 +0100)
The current design is that, for asynchronous events like link_up and
link_down firmware raises the interrupt to kernel. The previous patch
which added RPM_USX driver has a bug where it uses old csr addresses
for configuring interrupts. Which is resulting in losing interrupts
from source firmware.

This patch fixes the issue by correcting csr addresses.

Fixes: b9d0fedc6234 ("octeontx2-af: cn10kb: Add RPM_USX MAC support")
Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/octeontx2/af/rpm.c
drivers/net/ethernet/marvell/octeontx2/af/rpm.h

index de0d88dd10d65c74803e44e330a4cbf78e2eb00d..a433f92c51eae63bc6b44e287e27e0e71bcb5ab3 100644 (file)
@@ -47,7 +47,7 @@ static struct mac_ops         rpm2_mac_ops   = {
        .int_set_reg    =       RPM2_CMRX_SW_INT_ENA_W1S,
        .irq_offset     =       1,
        .int_ena_bit    =       BIT_ULL(0),
-       .lmac_fwi       =       RPM_LMAC_FWI,
+       .lmac_fwi       =       RPM2_LMAC_FWI,
        .non_contiguous_serdes_lane = true,
        .rx_stats_cnt   =       43,
        .tx_stats_cnt   =       34,
index 22147b4c21370720559837d8f5c1e9b784e883e1..be294eebab26512e06ebc3d35ec10c4334a43f17 100644 (file)
@@ -94,7 +94,8 @@
 
 /* CN10KB CSR Declaration */
 #define  RPM2_CMRX_SW_INT                              0x1b0
-#define  RPM2_CMRX_SW_INT_ENA_W1S                      0x1b8
+#define  RPM2_CMRX_SW_INT_ENA_W1S                      0x1c8
+#define  RPM2_LMAC_FWI                                 0x12
 #define  RPM2_CMR_CHAN_MSK_OR                          0x3120
 #define  RPM2_CMR_RX_OVR_BP_EN                         BIT_ULL(2)
 #define  RPM2_CMR_RX_OVR_BP_BP                         BIT_ULL(1)