Revert "arm64: smp: avoid NMI IPIs with broken MediaTek FW"
authorDouglas Anderson <dianders@chromium.org>
Tue, 7 Nov 2023 15:26:57 +0000 (07:26 -0800)
committerCatalin Marinas <catalin.marinas@arm.com>
Wed, 8 Nov 2023 15:38:47 +0000 (15:38 +0000)
This reverts commit a07a594152173a3dd3bdd12fc7d73dbba54cdbca.

This is no longer needed after the patch ("arm64: Move MediaTek GIC
quirk handling from irqchip to core).

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Marc Zyngier <maz@kernel.org>
Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20231107072651.v2.2.I2c5fa192e767eb3ee233bc28eb60e2f8656c29a6@changeid
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm64/kernel/smp.c
drivers/irqchip/irq-gic-v3.c

index 13fa576dd2c697babebf1156fc7a13c745052150..03204e841172057f5093ccee5503e09fc1e872a1 100644 (file)
@@ -965,10 +965,7 @@ static void smp_cross_call(const struct cpumask *target, unsigned int ipinr)
 
 static bool ipi_should_be_nmi(enum ipi_msg_type ipi)
 {
-       DECLARE_STATIC_KEY_FALSE(supports_pseudo_nmis);
-
-       if (!system_uses_irq_prio_masking() ||
-           !static_branch_likely(&supports_pseudo_nmis))
+       if (!system_uses_irq_prio_masking())
                return false;
 
        switch (ipi) {
index 552a3fed7a893c49fb0d3ce0c00b538e759df19e..dd41635547384e7de47cd21dca18fba94158c3fb 100644 (file)
@@ -105,7 +105,7 @@ static DEFINE_STATIC_KEY_TRUE(supports_deactivate_key);
  * - Figure 4-7 Secure read of the priority field for a Non-secure Group 1
  *   interrupt.
  */
-DEFINE_STATIC_KEY_FALSE(supports_pseudo_nmis);
+static DEFINE_STATIC_KEY_FALSE(supports_pseudo_nmis);
 
 DEFINE_STATIC_KEY_FALSE(gic_nonsecure_priorities);
 EXPORT_SYMBOL(gic_nonsecure_priorities);