nvmet: remove cntlid_min and cntlid_max check in nvmet_alloc_ctrl
authorGuixin Liu <kanie@linux.alibaba.com>
Wed, 13 Dec 2023 06:32:50 +0000 (14:32 +0800)
committerKeith Busch <kbusch@kernel.org>
Wed, 13 Dec 2023 22:53:33 +0000 (14:53 -0800)
The cntlid_min and cntlid_max are checked in configfs, don't check
again in nvmet_alloc_ctrl().

Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/target/core.c

index 3935165048e74199cd4a9706811dd7d63fc39476..d26aa30f87026058fb23a1df97d10c1fe7fafbda 100644 (file)
@@ -1425,9 +1425,6 @@ u16 nvmet_alloc_ctrl(const char *subsysnqn, const char *hostnqn,
        if (!ctrl->sqs)
                goto out_free_changed_ns_list;
 
-       if (subsys->cntlid_min > subsys->cntlid_max)
-               goto out_free_sqs;
-
        ret = ida_alloc_range(&cntlid_ida,
                             subsys->cntlid_min, subsys->cntlid_max,
                             GFP_KERNEL);