media: nxp: Fix wrong return pointer check in mxc_isi_crossbar_init()
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 25 Jul 2023 13:00:24 +0000 (21:00 +0800)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Thu, 10 Aug 2023 05:58:37 +0000 (07:58 +0200)
It should check 'xbar->inputs', when allocate memory for it.

Cc: stable@vger.kernel.org
Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c

index f7447b2f4d7779016acf543055be08452373dbf5..9fcfc39257332326b320b2964210478a053529f8 100644 (file)
@@ -483,7 +483,7 @@ int mxc_isi_crossbar_init(struct mxc_isi_dev *isi)
 
        xbar->inputs = kcalloc(xbar->num_sinks, sizeof(*xbar->inputs),
                               GFP_KERNEL);
-       if (!xbar->pads) {
+       if (!xbar->inputs) {
                ret = -ENOMEM;
                goto err_free;
        }