rtc: gamecube: Fix refcount leak in gamecube_rtc_read_offset_from_sram
authorMiaoqian Lin <linmq006@gmail.com>
Wed, 9 Mar 2022 09:22:25 +0000 (09:22 +0000)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Tue, 29 Mar 2022 20:45:50 +0000 (22:45 +0200)
The of_find_compatible_node() function returns a node pointer with
refcount incremented, We should use of_node_put() on it when done
Add the missing of_node_put() to release the refcount.

Fixes: 86559400b3ef ("rtc: gamecube: Add a RTC driver for the GameCube, Wii and Wii U")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20220309092225.6930-1-linmq006@gmail.com
drivers/rtc/rtc-gamecube.c

index f717b36f4738cf2513cf127c54653166a26d8056..18ca3b38b2d0474f58f4a56b3ae94d5afb3f86d9 100644 (file)
@@ -235,6 +235,7 @@ static int gamecube_rtc_read_offset_from_sram(struct priv *d)
        }
 
        ret = of_address_to_resource(np, 0, &res);
+       of_node_put(np);
        if (ret) {
                pr_err("no io memory range found\n");
                return -1;