thermal/drivers/imx_sc_thermal: Fix the loop condition
authorViorel Suman <viorel.suman@nxp.com>
Tue, 17 Jan 2023 09:19:55 +0000 (11:19 +0200)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Tue, 17 Jan 2023 09:28:07 +0000 (10:28 +0100)
The minimal resource ID is 0: IMX_SC_R_AP_0=0, so fix
the loop condition. Aside of this - constify the array.

Fixes: 31fd4b9db13b ("thermal/drivers/imx_sc: Rely on the platform data to get the resource id")
Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
Reviewed-by: Dong Aisheng <Aisheng.dong@nxp.com>
Link: https://lore.kernel.org/r/20230117091956.61729-1-viorel.suman@oss.nxp.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
drivers/thermal/imx_sc_thermal.c

index 4df925e3a80bd72951844e697319df9bb03d0512..dfadb03580ae19aa668c8d50546093acfdddbe2b 100644 (file)
@@ -88,7 +88,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
        if (!resource_id)
                return -EINVAL;
 
-       for (i = 0; resource_id[i] > 0; i++) {
+       for (i = 0; resource_id[i] >= 0; i++) {
 
                sensor = devm_kzalloc(&pdev->dev, sizeof(*sensor), GFP_KERNEL);
                if (!sensor)
@@ -127,7 +127,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
        return 0;
 }
 
-static int imx_sc_sensors[] = { IMX_SC_R_SYSTEM, IMX_SC_R_PMIC_0, -1 };
+static const int imx_sc_sensors[] = { IMX_SC_R_SYSTEM, IMX_SC_R_PMIC_0, -1 };
 
 static const struct of_device_id imx_sc_thermal_table[] = {
        { .compatible = "fsl,imx-sc-thermal", .data =  imx_sc_sensors },