bcache: pr_info() format clean up in bcache_device_init()
authorColy Li <colyli@suse.de>
Sun, 14 Jun 2020 16:53:33 +0000 (00:53 +0800)
committerJens Axboe <axboe@kernel.dk>
Sun, 14 Jun 2020 22:47:56 +0000 (16:47 -0600)
scripts/checkpatch.pl reports following warning for patch
("bcache: check and adjust logical block size for backing devices"),
    WARNING: quoted string split across lines
    #146: FILE: drivers/md/bcache/super.c:896:
    +  pr_info("%s: sb/logical block size (%u) greater than page size "
    +        "(%lu) falling back to device logical block size (%u)",

There are two things to fix up,
- The kernel message print should be in a single line.
- pr_info() won't automatically add new line since v5.8, a '\n' should
  be added.

This patch just does the above cleanup in bcache_device_init().

Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/md/bcache/super.c

index a6e79083010af4905483868db5c68747fb9ef183..2014016f9a60d301f9762ae2436ff2202f7fe131 100644 (file)
@@ -893,8 +893,7 @@ static int bcache_device_init(struct bcache_device *d, unsigned int block_size,
                 * This should only happen with BCACHE_SB_VERSION_BDEV.
                 * Block/page size is checked for BCACHE_SB_VERSION_CDEV.
                 */
-               pr_info("%s: sb/logical block size (%u) greater than page size "
-                       "(%lu) falling back to device logical block size (%u)",
+               pr_info("%s: sb/logical block size (%u) greater than page size (%lu) falling back to device logical block size (%u)\n",
                        d->disk->disk_name, q->limits.logical_block_size,
                        PAGE_SIZE, bdev_logical_block_size(cached_bdev));